]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Btrfs: fix tree corruption after multi-thread snapshots and inode_cache flush
authorLiu Bo <liubo2009@cn.fujitsu.com>
Tue, 15 Nov 2011 01:48:06 +0000 (20:48 -0500)
committerChris Mason <chris.mason@oracle.com>
Tue, 15 Nov 2011 14:53:28 +0000 (09:53 -0500)
commitf1ebcc74d5b2159f44c96b479b6eb8afc7829095
tree83d949e151f2f7e4a980396538cc0f2356bacfd4
parent8965593e41dd2d0e2a2f1e6f245336005ea94a2c
Btrfs: fix tree corruption after multi-thread snapshots and inode_cache flush

The btrfs snapshotting code requires that once a root has been
snapshotted, we don't change it during a commit.

But there are two cases to lead to tree corruptions:

1) multi-thread snapshots can commit serveral snapshots in a transaction,
   and this may change the src root when processing the following pending
   snapshots, which lead to the former snapshots corruptions;

2) the free inode cache was changing the roots when it root the cache,
   which lead to corruptions.

This fixes things by making sure we force COW the block after we create a
snapshot during commiting a transaction, then any changes to the roots
will result in COW, and we get all the fs roots and snapshot roots to be
consistent.

Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
fs/btrfs/ctree.c
fs/btrfs/ctree.h
fs/btrfs/transaction.c