]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
media: videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 19 Nov 2018 15:33:44 +0000 (10:33 -0500)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitf1eeb90723a4db100d10f843dfc716778e7fc802
tree6522282c668684c3756fe18d61f6cbc3e29e3c3e
parent0d3ec953b674193482c1ce0cac81aec7ea3d02b6
media: videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()

BugLink: https://bugs.launchpad.net/bugs/1837952
commit 5e99456c20f712dcc13d9f6ca4278937d5367355 upstream.

Userspace shouldn't set bytesused to 0 for output buffers.
vb2_warn_zero_bytesused() warns about this (only once!), but it also
calls WARN_ON(1), which is confusing since it is not immediately clear
that it warns about a 0 value for bytesused.

Just drop the WARN_ON as it serves no purpose.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Matthias Maennich <maennich@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/media/v4l2-core/videobuf2-v4l2.c