]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
hamradio: defer 6pack kfree after unregister_netdev
authorLin Ma <linma@zju.edu.cn>
Mon, 8 Nov 2021 10:37:59 +0000 (18:37 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:42:04 +0000 (14:42 +0200)
commitf287502e20b518e9cf684fd515d206af6b8cb0ba
treeae0ec131910fa08183879acf81335237437f5d9b
parentbe87be8fcfc7d5dd057032dd841f90e417d63b69
hamradio: defer 6pack kfree after unregister_netdev

BugLink: https://bugs.launchpad.net/bugs/1969857
commit 0b9111922b1f399aba6ed1e1b8f2079c3da1aed8 upstream.

There is a possible race condition (use-after-free) like below

 (USE)                       |  (FREE)
  dev_queue_xmit             |
   __dev_queue_xmit          |
    __dev_xmit_skb           |
     sch_direct_xmit         | ...
      xmit_one               |
       netdev_start_xmit     | tty_ldisc_kill
        __netdev_start_xmit  |  6pack_close
         sp_xmit             |   kfree
          sp_encaps          |
                             |

According to the patch "defer ax25 kfree after unregister_netdev", this
patch reorder the kfree after the unregister_netdev to avoid the possible
UAF as the unregister_netdev() is well synchronized and won't return if
there is a running routine.

Signed-off-by: Lin Ma <linma@zju.edu.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Xu Jia <xujia39@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/hamradio/6pack.c