]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
[PATCH] knfsd: Fix two problems that can cause rmmod nfsd to die
authorNeilBrown <neilb@suse.de>
Tue, 23 May 2006 05:35:25 +0000 (22:35 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Tue, 23 May 2006 17:35:31 +0000 (10:35 -0700)
commitf2d395865faa2a7cd4620b07178e58cbb160ba08
tree01d3b090a4ce73eb346a2c55d99fe12d07d52906
parente46e490368f87032a6e54969194413339b35a385
[PATCH] knfsd: Fix two problems that can cause rmmod nfsd to die

Both cause the 'entries' count in the export cache to be non-zero at module
removal time, so unregistering that cache fails and results in an oops.

1/ exp_pseudoroot (used for NFSv4 only) leaks a reference to an export
   entry.
2/ sunrpc_cache_update doesn't increment the entries count when it adds
   an entry.

Thanks to "david m.  richter" <richterd@citi.umich.edu> for triggering the
problem and finding one of the bugs.

Cc: "david m. richter" <richterd@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/nfsd/export.c
net/sunrpc/cache.c