]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: virtio: use eth_hw_addr_set()
authorJakub Kicinski <kuba@kernel.org>
Wed, 27 Oct 2021 15:20:12 +0000 (08:20 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Oct 2021 14:47:30 +0000 (07:47 -0700)
commitf2edaa4ad5d51371709196f2c258fbe875962dee
treec512d6a3a8bc075c1167258e08046ef5b9fb88fd
parentee775b56950faef934d6e9c2252de6e2e5a8e912
net: virtio: use eth_hw_addr_set()

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it go through appropriate helpers.

Even though the current code uses dev->addr_len the we can switch
to eth_hw_addr_set() instead of dev_addr_set(). The netdev is
always allocated by alloc_etherdev_mq() and there are at least two
places which assume Ethernet address:
 - the line below calling eth_hw_addr_random()
 - virtnet_set_mac_address() -> eth_commit_mac_addr_change()

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Link: https://lore.kernel.org/r/20211027152012.3393077-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/virtio_net.c