]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nfp: change eeprom length to max length enumerators
authorJaco Coetzee <jaco.coetzee@corigine.com>
Wed, 9 Nov 2022 20:27:57 +0000 (15:27 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Nov 2022 10:45:38 +0000 (10:45 +0000)
commitf3a72878a3de720661b7ed0d6b7f7c506ddb8a52
treedfe09c9200df3849887b75979f5d113dc9bc0bcc
parent4bbf3422df78029f03161640dcb1e9d1ed64d1ea
nfp: change eeprom length to max length enumerators

Extend the size of QSFP EEPROM for types SSF8436 and SFF8636
from 256 to 640 bytes in order to expose all the EEPROM pages by
ethtool.

For SFF-8636 and SFF-8436 specifications, the driver exposes
256 bytes of EEPROM data for ethtool's get_module_eeprom()
callback, resulting in "netlink error: Invalid argument" when
an EEPROM read with an offset larger than 256 bytes is attempted.

Changing the length enumerators to the _MAX_LEN
variants exposes all 640 bytes of the EEPROM allowing upper
pages 1, 2 and 3 to be read.

Fixes: 96d971e307cc ("ethtool: Add fallback to get_module_eeprom from netlink command")
Signed-off-by: Jaco Coetzee <jaco.coetzee@corigine.com>
Reviewed-by: Louis Peens <louis.peens@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c