]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
amd-xgbe: Fix debugfs compatibility change with kstrtouint
authorLendacky, Thomas <Thomas.Lendacky@amd.com>
Wed, 2 Jul 2014 18:04:28 +0000 (13:04 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jul 2014 04:38:06 +0000 (21:38 -0700)
commitf3f128d40c4cc263af8e30b009a3eb17655e912b
treea477da84355de899d9706d279bee0448532e8ff8
parentdb55b62cab8d458aba4e7a81dc4dd98b45c03d85
amd-xgbe: Fix debugfs compatibility change with kstrtouint

The initial change from sscanf to kstrtouint broke backward
compatbility by using a base of "0" in the kstrtouint call.
This allowed for entering decimal, hexadecimal or octal as
input where previously the sscanf always interpreted the input
as hexadecimal.  Additionally, -EIO was returned on error prior
to this change and now it is whatever the error value that is
returned by kstrtouint.

Change the base value of the kstrtouint from 0 to 16 and return
-EIO on error.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/xgbe/xgbe-debugfs.c