]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
pinctrl: qcom: Use return value from irq_set_wake() call
authorMaulik Shah <mkshah@codeaurora.org>
Mon, 28 Sep 2020 04:32:00 +0000 (10:02 +0530)
committerMarc Zyngier <maz@kernel.org>
Tue, 6 Oct 2020 10:23:14 +0000 (11:23 +0100)
commitf41aaca593377a4fe3984459fd4539481263b4cd
tree6ef6a9d4ed07b1f2b85dbf124b9926b149ada383
parentc5f72aeb659eb2f809b9531d759651514d42aa3a
pinctrl: qcom: Use return value from irq_set_wake() call

msmgpio irqchip was not using return value of irq_set_irq_wake() callback
since previously GIC-v3 irqchip neither had IRQCHIP_SKIP_SET_WAKE flag nor
it implemented .irq_set_wake callback. This lead to irq_set_irq_wake()
return error -ENXIO.

However from 'commit 4110b5cbb014 ("irqchip/gic-v3: Allow interrupt to be
configured as wake-up sources")' GIC irqchip has IRQCHIP_SKIP_SET_WAKE
flag.

Use return value from irq_set_irq_wake() and irq_chip_set_wake_parent()
instead of always returning success.

Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy")
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Tested-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/1601267524-20199-3-git-send-email-mkshah@codeaurora.org
drivers/pinctrl/qcom/pinctrl-msm.c