]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
perf sched timehist: Improve error message when analyzing wrong file
authorDavid Ahern <dsahern@gmail.com>
Tue, 29 Nov 2016 20:39:48 +0000 (13:39 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 7 Dec 2016 15:00:32 +0000 (12:00 -0300)
commitf45bf8d3939d8f32f06ec12e56d2b8651c5437b4
tree95fe80b695ed7ae6cc265dd0f470df4782227607
parent8ac1eb7bab7c8d9d6f00b3e2a408611c45d9dff0
perf sched timehist: Improve error message when analyzing wrong file

Arnaldo reported an unhelpful error message when running perf sched
timehist on a file that did not contain sched tracepoints:

    [root@jouet ~]# perf sched timehist
    No trace sample to read. Did you call 'perf record -R'?

    [root@jouet ~]# perf evlist -v
    cycles:ppp: size: 112, { sample_period, sample_freq }: 4000, sample_type: IP|TID|TIME|CALLCHAIN|CPU|PERIOD, disabled: 1, inherit: 1, mmap: 1, comm: 1, freq: 1, task: 1, precise_ip: 3, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1

Change the has_traces check to look for the sched_switch event. Analysis
for perf sched timehist requires at least this event.

Now when analyzing a file without sched tracepoints you get:

    root@f21-vbox:/tmp$ perf sched timehist
    No sched_switch events found. Have you run 'perf sched record'?

Signed-off-by: David Ahern <dsahern@gmail.com>
Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1480451988-43673-1-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-sched.c