]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
scsi: NCR5380: Don't clear busy flag when abort fails
authorFinn Thain <fthain@telegraphics.com.au>
Thu, 27 Sep 2018 01:17:11 +0000 (11:17 +1000)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 26 Nov 2019 12:16:55 +0000 (13:16 +0100)
commitf460c80d86fb38706361db417dd390d0a5f88913
treea66c2d4b8233f19024b21d71777603248f4eb6cc
parent38130ffb6a2e6962880225e39cb9e2ea4fa5709e
scsi: NCR5380: Don't clear busy flag when abort fails

BugLink: https://bugs.launchpad.net/bugs/1853915
[ Upstream commit 45ddc1b24806cc8f1a09f23dd4e7b6e4a8ae36e1 ]

When NCR5380_abort() returns FAILED, the driver forgets that the target is
still busy. Hence, further commands may be sent to the target, which may fail
during selection and produce the error message, "reselection after won
arbitration?". Prevent this by leaving the busy flag set when NCR5380_abort()
fails.

Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/scsi/NCR5380.c