]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
ALSA: usb-audio: fix combine_word problem
authorJulian Anastasov <ja@ssi.bg>
Fri, 6 Nov 2009 21:44:53 +0000 (23:44 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sat, 7 Nov 2009 08:46:06 +0000 (09:46 +0100)
commitf495088210c8b9e20791d995a8210170c68d2deb
tree4f18e905dd9a21400d9327c9f79847afa7a95535
parent70edc800a39327174d3244f9226ce8cacd01dc91
ALSA: usb-audio: fix combine_word problem

Fix combine_word problem where first octet is not
read properly. The only affected place seems to be the
INPUT_TERMINAL type. Before now, sound controls can be created
with the output terminal's name which is a fallback mechanism
used only for unknown input terminal types. For example,
Line can wrongly appear as Speaker. After the change it
should appear as Line.

The side effect of this change can be that users
can expect the wrong control name in their scripts or
programs while now we return the correct one.

Probably, these defines should use get_unaligned_le16 and
friends.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/usbaudio.h