]> git.proxmox.com Git - mirror_frr.git/commit
bgpd: Fix route install upon non-best nexthop change
authorvivek <vivek@cumulusnetworks.com>
Mon, 5 Sep 2016 17:35:19 +0000 (10:35 -0700)
committervivek <vivek@cumulusnetworks.com>
Tue, 6 Sep 2016 19:37:43 +0000 (12:37 -0700)
commitf4b6d7e9bf3e2e5c575c85060d86d1403a08bd30
tree12ed53068f6b22dd297e622ad4733c6c73c76c79
parent9374cd9b5b395ee97d0c376f83add1f8950f060b
bgpd: Fix route install upon non-best nexthop change

After BGP path selection, even if the best route entry selected has not
changed, ensure that the route is installed again in zebra if any non-best
but multipath route entry has a nexthop resolution change.

In the absence of this fix, if a non-best multipath route entry had a
nexthop resolution change (such as being resolved over two first hops instead
of one), the route would get reinstalled into zebra only in some situations
(i.e., when the best route entry had its IGP change flag set). If the route
does not get reinstalled by BGP, the corresponding route in the zebra RIB
would not have all the first hops.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Sid Khot <sidkhot@cumulusnetworks.com>
Ticket: CM-12390
Reviewed By: CCR-5134
Testing Done: Manual, bgp-smoke

(cherry picked from commit 3064bf43a7d8162dadada2934132f915a45d2bcb)
bgpd/bgp_nht.c
bgpd/bgp_route.c