]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
hwrng: omap - Only fail if pm_runtime_get_sync returns < 0
authorDave Gerlach <d-gerlach@ti.com>
Tue, 20 Sep 2016 15:25:40 +0000 (10:25 -0500)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Nov 2016 16:46:20 +0000 (16:46 +0000)
commitf4e07d9b63f4eb27ae4116127472ec6f926e6d05
tree61d651c76def3fdf28aef2fdd0f4b45167ffe16b
parent4f404d911bbe24c12b56c4bc963890c8b0ea09d2
hwrng: omap - Only fail if pm_runtime_get_sync returns < 0

BugLink: http://bugs.launchpad.net/bugs/1638267
commit ad8529fde9e3601180a839867a8ab041109aebb5 upstream.

Currently omap-rng checks the return value of pm_runtime_get_sync and
reports failure if anything is returned, however it should be checking
if ret < 0 as pm_runtime_get_sync return 0 on success but also can return
1 if the device was already active which is not a failure case. Only
values < 0 are actual failures.

Fixes: 61dc0a446e5d ("hwrng: omap - Fix assumption that runtime_get_sync will always succeed")
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/char/hw_random/omap-rng.c