]> git.proxmox.com Git - mirror_qemu.git/commit
pci-hotplug-old: Has been dead for five major releases, bury
authorMarkus Armbruster <armbru@redhat.com>
Thu, 26 Feb 2015 16:21:13 +0000 (17:21 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 1 Mar 2015 11:37:54 +0000 (12:37 +0100)
commitf51074cdc6e750daa3b6df727d83449a7e42b391
tree87af0f83b6e5b4c9e093e5e312b6aa5e6fae5073
parent6dbcb81956b16d794c9c0257b94bd4c6feba713f
pci-hotplug-old: Has been dead for five major releases, bury

Commit 79ca616 (v1.6.0) accidentally disabled legacy x86-only HMP
commands pci_add, pci_del: it defined CONFIG_PCI_HOTPLUG only as make
variable, not as preprocessor macro, killing the code conditional on
defined(CONFIG_PCI_HOTPLUG_OLD).

In all this time, nobody reported the loss.  I only noticed it when I
tried to test some error reporting change that forced me to touch this
old crap again.

Fun: git-log hw/pci/pci-hotplug-old.c shows our faith in the backward
compatibility god has been strong enough to sacrifice at its altar
about a dozen times, but not strong enough to even once verify the
legacy feature's still there, let alone works.

Remove the commands along with the code backing them.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
default-configs/i386-softmmu.mak
default-configs/x86_64-softmmu.mak
device-hotplug.c
hmp-commands.hx
hw/pci/Makefile.objs
hw/pci/pci-hotplug-old.c [deleted file]
include/sysemu/blockdev.h
include/sysemu/sysemu.h
stubs/Makefile.objs
stubs/pci-drive-hot-add.c [deleted file]