]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drivers/rtc/rtc-hym8563.c: fix swapped enable/disable of clockout control bit
authorHeiko Stübner <heiko@sntech.de>
Thu, 16 Apr 2015 19:46:11 +0000 (12:46 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 17 Apr 2015 13:04:02 +0000 (09:04 -0400)
commitf539a8acf1070557aef9c5df682751ba2af1005f
tree33fb2c970dd0c91e5f0539e0643ed8ff7d2be99b
parent492da68c8c3babc573208e057a9011d9489f2b5a
drivers/rtc/rtc-hym8563.c: fix swapped enable/disable of clockout control bit

The hym8563 datasheet describes the clock output control-bit as "when set
to logic 0, the square wave output is enable, when set to logic 1, the
CLKOUT output is inhibited".  But in reality the setting is exactly
opposite.

Before now, the clock output was not really used, but on the rk3288 soc
this generated clock is used to supply the temperature sensor block and
the swapped bit value prevented it from working.  With the corrected
value, the tsadc now reports correct values.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-hym8563.c