]> git.proxmox.com Git - mirror_ovs.git/commit
Revert "tunneling: Avoid recirculation on datapath."
authorJoe Stringer <joe@ovn.org>
Mon, 8 May 2017 18:15:39 +0000 (11:15 -0700)
committerJoe Stringer <joe@ovn.org>
Wed, 10 May 2017 19:14:02 +0000 (12:14 -0700)
commitf5f64552ec22f4c7452fdb554d52e73055b51cca
treea68706423960d043f3858c0cbe7563fb0191cbb0
parentc847a84c4a11489910319d93ef22dfeef8e1b1f8
Revert "tunneling: Avoid recirculation on datapath."

This reverts commit f1dac5128ce6db2e493f0d1c7a8b53fb9f34476f. When this
commit was introduced, it broke the 'make check-system-userspace'
testsuite. It appears that the new translation fails to modify the flow
in a way that would represent the flow as an encapsulated flow when the
traffic is patched through to the second bridge. As such, rather than
matching on, for example, "ip,proto=47" for gre, it would use the inner
packet's flow headers. It also results in problems reporting statistics,
as the tunnel's header is not reflected in subsequent statistics and
truncation is not properly applied during translation.

While a refreshed approach to solving the above problem is formed,
revert this patch.

Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/331972.html
Signed-off-by: Joe Stringer <joe@ovn.org>
Acked-by: Greg Rose <gvrose8192@gmail.com>
lib/dpif-netdev.c
ofproto/ofproto-dpif-xlate.c
tests/ofproto-dpif.at
tests/ovn.at
tests/tunnel-push-pop-ipv6.at
tests/tunnel-push-pop.at