]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
block: assert that we're not holding open_mutex over blk_report_disk_dead
authorChristian Brauner <brauner@kernel.org>
Tue, 17 Oct 2023 18:48:22 +0000 (20:48 +0200)
committerChristian Brauner <brauner@kernel.org>
Sat, 28 Oct 2023 11:29:23 +0000 (13:29 +0200)
commitf61033390bc34cd22ad4b4c12619a1e7a8a75600
tree30879c8a54542a6d09eb575dc36b046356dbc592
parent6e57236ed6e070607868da70fac3d52ae24e5417
block: assert that we're not holding open_mutex over blk_report_disk_dead

blk_report_disk_dead() has the following major callers:

(1) del_gendisk()
(2) blk_mark_disk_dead()

Since del_gendisk() acquires disk->open_mutex it's clear that all
callers are assumed to be called without disk->open_mutex held.
In turn, blk_report_disk_dead() is called without disk->open_mutex held
in del_gendisk().

All callers of blk_mark_disk_dead() call it without disk->open_mutex as
well.

Ensure that it is clear that blk_report_disk_dead() is called without
disk->open_mutex on purpose by asserting it and a comment in the code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20231017184823.1383356-5-hch@lst.de
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
block/genhd.c