]> git.proxmox.com Git - mirror_frr.git/commit
*: `frr-format` with unmodified GCC
authorDavid Lamparter <equinox@opensourcerouting.org>
Tue, 28 Sep 2021 09:20:32 +0000 (11:20 +0200)
committerDavid Lamparter <equinox@opensourcerouting.org>
Tue, 28 Sep 2021 09:20:32 +0000 (11:20 +0200)
commitf62de63c6a0cf38ea20ecdb35194424be06c01fe
tree9c529653d39a100e6a20a12dc8758e6439c908d6
parent01236d7aa7dab0891fa25012f87bc1fe3bbcfe9b
*: `frr-format` with unmodified GCC

Since there's very few locations where the `frr-format` actually prints
false positive warnings, consensus seems to be to just work around the
false positives even if the code is correct.

In fact, there is only one pattern of false positives currently, in
`bfdd/dplane.c` which does `vty_out("%"PRIu64, (uint64_t)be64toh(...))`.
The workaround/fix for this is a replacement `be64toh` whose type is
always `uint64_t` regardless of what OS we're on, making the cast
unnecessary.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
bfdd/dplane.c
doc/developer/workflow.rst
lib/network.h