]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning
authorTorin Cooper-Bennun <torin@maxiluxsystems.com>
Wed, 3 Mar 2021 10:31:52 +0000 (10:31 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 23 Apr 2021 09:56:09 +0000 (11:56 +0200)
commitf66e933dd80e65ea9f65a22bb32b7a7453f94ab4
treecb9a6a31cd89fde2cefa70f35b36931aee0e3fe7
parent48f1ac7cc61d967d70d7f928622ac859af462313
can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning

BugLink: https://bugs.launchpad.net/bugs/1923220
[ Upstream commit c0e399f3baf42279f48991554240af8c457535d1 ]

Message loss from RX FIFO 0 is already handled in
m_can_handle_lost_msg(), with netdev output included.

Removing this warning also improves driver performance under heavy
load, where m_can_do_rx_poll() may be called many times before this
interrupt is cleared, causing this message to be output many
times (thanks Mariusz Madej for this report).

Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
Link: https://lore.kernel.org/r/20210303103151.3760532-1-torin@maxiluxsystems.com
Reported-by: Mariusz Madej <mariusz.madej@xtrack.com>
Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/can/m_can/m_can.c