]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
[media] V4L2: soc-camera: fix uninitialised use compiler warning
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Mon, 24 Jun 2013 08:19:19 +0000 (05:19 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 28 Jun 2013 17:57:18 +0000 (14:57 -0300)
commitf687f3263e99e34289e076352fad23974ee072ab
treeea1d391a59d1ce8a5e2f431ad2422745b65cf3d1
parentfe05e141a4d70d9417fd628133ecb32851f2e136
[media] V4L2: soc-camera: fix uninitialised use compiler warning

In scan_async_group() if the size parameter is negative, the sasd pointer
will be used uninitialised:
drivers/media/platform/soc_camera/soc_camera.c: In function "soc_camera_host_register":
drivers/media/platform/soc_camera/soc_camera.c:1514:55: warning: "sasd" may
be used uninitialized in this function [-Wmaybe-uninitialized]
    sasd->asd.match.i2c.adapter_id, sasd->asd.match.i2c.address);
                                                       ^
drivers/media/platform/soc_camera/soc_camera.c:1464:34: note: "sasd" was
declared here
  struct soc_camera_async_subdev *sasd;
Fix this by making "size" and the array, from which it is assigned unsigned.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/soc_camera/soc_camera.c
include/media/sh_mobile_ceu.h
include/media/soc_camera.h