]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ALSA: ice1724: Fix sleep-in-atomic in Infrasonic Quartet support code
authorTakashi Iwai <tiwai@suse.de>
Wed, 18 Dec 2019 19:26:06 +0000 (20:26 +0100)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 06:00:53 +0000 (01:00 -0500)
commitf69a744ff95f7e871854a777a7e6298b72c84464
tree4eafb49a51eca4a47696a693ed04f7eb75b5dcc2
parent687911107045c3eaa5d671ccbb535b73fa946e4f
ALSA: ice1724: Fix sleep-in-atomic in Infrasonic Quartet support code

BugLink: https://bugs.launchpad.net/bugs/1861710
commit 0aec96f5897ac16ad9945f531b4bef9a2edd2ebd upstream.

Jia-Ju Bai reported a possible sleep-in-atomic scenario in the ice1724
driver with Infrasonic Quartet support code: namely, ice->set_rate
callback gets called inside ice->reg_lock spinlock, while the callback
in quartet.c holds ice->gpio_mutex.

This patch fixes the invalid call: it simply moves the calls of
ice->set_rate and ice->set_mclk callbacks outside the spinlock.

Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/5d43135e-73b9-a46a-2155-9e91d0dcdf83@gmail.com
Link: https://lore.kernel.org/r/20191218192606.12866-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/pci/ice1712/ice1724.c