]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
MIPS: RB532: fix return value of __setup handler
authorRandy Dunlap <rdunlap@infradead.org>
Sat, 12 Mar 2022 04:20:26 +0000 (20:20 -0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:39:09 +0000 (14:39 +0200)
commitf6eba65625c840af5d86e2beb0e02974fd692e3c
tree23ee928f327da96225014addeb3a477d1dd89050
parentb9d17ee986c7ecf271d093c7dba3266699906e14
MIPS: RB532: fix return value of __setup handler

BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 8755d57ba1ff910666572fab9e32890e8cc6ed3b ]

__setup() handlers should return 1 to obsolete_checksetup() in
init/main.c to indicate that the boot option has been handled.
A return of 0 causes the boot option/value to be listed as an Unknown
kernel parameter and added to init's (limited) argument or environment
strings. Also, error return codes don't mean anything to
obsolete_checksetup() -- only non-zero (usually 1) or zero.
So return 1 from setup_kmac().

Fixes: 9e21c7e40b7e ("MIPS: RB532: Replace parse_mac_addr() with mac_pton().")
Fixes: 73b4390fb234 ("[MIPS] Routerboard 532: Support for base system")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
From: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Phil Sutter <n0-1@freewrt.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Daniel Walter <dwalter@google.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit d5e41310bd72e70c90ab9cb2d5b57da88c75a0e3)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
arch/mips/rb532/devices.c