]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
spi: armada-3700: fix unsigned compare than zero on irq
authorColin Ian King <colin.king@canonical.com>
Tue, 13 Dec 2016 10:28:12 +0000 (10:28 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 14 Dec 2016 17:38:51 +0000 (17:38 +0000)
commitf6f0083cca66e673cca6fa26b52b107b5570081d
tree5399f903bd7c5b6c28aac979865670b70cd8306f
parentfafd67940774733fa97f4b09412aea6981b82e0a
spi: armada-3700: fix unsigned compare than zero on irq

spi->irq is an unsigned integer hence the check if status is less than
zero has no effect.  Fix this by replacing spi->irq with an int irq
so the less than zero compare will correctly detect errors.

Issue found with static analysis with CoverityScan, CID1388567

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Romain Perier <romain.perier@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-armada-3700.c