]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
i40iw: fix null pointer dereference on a null wqe pointer
authorColin Ian King <colin.king@canonical.com>
Wed, 1 Apr 2020 22:49:21 +0000 (23:49 +0100)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 14 Apr 2020 18:44:50 +0000 (15:44 -0300)
commitf70968f05de4e7c24d839ca0d3e40f17c8024498
tree1d435e19a2d9c49086cf60ca7057445308e60726
parent8f3d9f354286745c751374f5f1fcafee6b3f3136
i40iw: fix null pointer dereference on a null wqe pointer

Currently the null check for wqe is incorrect and lets a null wqe
be passed to set_64bit_val and this indexes into the null pointer
causing a null pointer dereference.  Fix this by fixing the null
pointer check to return an error if wqe is null.

Link: https://lore.kernel.org/r/20200401224921.405279-1-colin.king@canonical.com
Addresses-Coverity: ("dereference after a null check")
Fixes: 4b34e23f4eaa ("i40iw: Report correct firmware version")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/i40iw/i40iw_ctrl.c