]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
workqueue: simplify wq_update_unbound_numa()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 12 May 2015 12:32:30 +0000 (20:32 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 18 May 2015 20:22:57 +0000 (16:22 -0400)
commitf7142ed483f49f9108bea1be0c1afcd5d9098e05
treefd817533489b688026cbc94d4a0ec2cbec03b85b
parent5b95e1af8d17d85a17728f6de7dbff538e6e3c49
workqueue: simplify wq_update_unbound_numa()

wq_update_unbound_numa() is known be called with wq_pool_mutex held.

But wq_update_unbound_numa() requests wq->mutex before reading
wq->unbound_attrs, wq->numa_pwq_tbl[] and wq->dfl_pwq.  But these fields
were changed to be allowed being read with wq_pool_mutex held.  So we
simply remove the mutex_lock(&wq->mutex).

Without the dependence on the the mutex_lock(&wq->mutex), the test
of wq->unbound_attrs->no_numa can also be moved upward.

The old code need a long comment to describe the stableness of
@wq->unbound_attrs which is also guaranteed by wq_pool_mutex now,
so we don't need this such comment.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c