]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
sched: Remove lockdep check in sched_move_task()
authorKirill Tkhai <ktkhai@parallels.com>
Tue, 28 Oct 2014 05:24:34 +0000 (08:24 +0300)
committerIngo Molnar <mingo@kernel.org>
Tue, 4 Nov 2014 06:07:30 +0000 (07:07 +0100)
commitf7b8a47da17c9ee4998f2ca2018fcc424e953c0e
tree90a76aa80a49f4a93b1dc162a26323f4661e893d
parent980d0d51b1c9617a472b2c0fcbe33d2d15eadc4c
sched: Remove lockdep check in sched_move_task()

sched_move_task() is the only interface to change sched_task_group:
cpu_cgrp_subsys methods and autogroup_move_group() use it.

Everything is synchronized by task_rq_lock(), so cpu_cgroup_attach()
is ordered with other users of sched_move_task(). This means we do no
need RCU here: if we've dereferenced a tg here, the .attach method
hasn't been called for it yet.

Thus, we should pass "true" to task_css_check() to silence lockdep
warnings.

Fixes: eeb61e53ea19 ("sched: Fix race between task_group and sched_task_group")
Reported-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1414473874.8574.2.camel@tkhai
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c