]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
drm/rockchip: Suspend DP late
authorDouglas Anderson <dianders@chromium.org>
Fri, 2 Aug 2019 18:46:16 +0000 (11:46 -0700)
committerSean Paul <seanpaul@chromium.org>
Mon, 5 Aug 2019 14:26:12 +0000 (10:26 -0400)
commitf7ccbed656f78212593ca965d9a8f34bf24e0aab
treec0a4171dcd478cc0e5ec8bc3aa6b3df99a98f383
parent9b562437d388582f5463a4c3f60ee97a2d4d8d58
drm/rockchip: Suspend DP late

In commit fe64ba5c6323 ("drm/rockchip: Resume DP early") we moved
resume to be early but left suspend at its normal time.  This seems
like it could be OK, but casues problems if a suspend gets interrupted
partway through.  The OS only balances matching suspend/resume levels.
...so if suspend was called then resume will be called.  If suspend
late was called then resume early will be called.  ...but if suspend
was called resume early might not get called.  This leads to an
unbalance in the clock enables / disables.

Lets take the simple fix and just move suspend to be late to match.
This makes the PM core take proper care in keeping things balanced.

Fixes: fe64ba5c6323 ("drm/rockchip: Resume DP early")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190802184616.44822-1-dianders@chromium.org
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c