]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: nomadik: shut up a warning for flags
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 15 Aug 2013 19:26:26 +0000 (21:26 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 15 Aug 2013 20:12:46 +0000 (22:12 +0200)
commitf84b4171312a59924c22b817c8f83c1749a8e8ba
treec1a83f5bfe727cef670d96f22e88fb757ec6f624
parenta1bc260bb5f5d95da854be7898202d788e94448d
pinctrl: nomadik: shut up a warning for flags

The irq flags variable gets a warning like this after
commit bf4dae5ce1b95a5932e43036edcf3f1b324758c6
"pinctrl: nomadik: delete ancient pin control API":

In file included from include/linux/seqlock.h:29:0,
                 from include/linux/time.h:5,
                 from include/linux/stat.h:18,
                 from include/linux/module.h:10,
                 from
drivers/pinctrl/pinctrl-nomadik.c:14:
drivers/pinctrl/pinctrl-nomadik.c: In function 'nmk_pmx_enable':
include/linux/spinlock.h:348:122: warning:
'flags' may be used uninitialized in this function
[-Wmaybe-uninitialized]
  raw_spin_unlock_irqrestore(&lock->rlock, flags);
                                                   ^
drivers/pinctrl/pinctrl-nomadik.c:1515:16: note:
'flags' was declared here
  unsigned long flags;

The function is question was never changed but it appears
the semantic checker could previously determine that the code
path that would use the flags was going to either use it or
not, but now it can't for some reason. Just fix it up.

Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-nomadik.c