]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
staging: ks7010: fix function return code path
authorTobin C. Harding <me@tobin.cc>
Mon, 10 Apr 2017 03:15:46 +0000 (13:15 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Apr 2017 14:03:36 +0000 (16:03 +0200)
commitf8641485ffb4ba573daa3f7d0532720634e5f44b
treea58125f90c8f651ab5affc36ff4fea0712c39f08
parent482c03c7b5f6d323f333ae59bf1c55ef2e24b1f2
staging: ks7010: fix function return code path

Function has duplicate code clean up sequences; identical function
call followed by return. This would be better expressed with the use
of a goto statement, as is typical in-tree.

One call site places the clean up code within the 'else' branch of an
multi-way decision. This can be more clearly expressed by inverting
the initial decision conditional and jumping directly to the cleanup
code. Subsequent code indentation can then be reduced, aiding
readability.

Fix function return code execution path. Move clean up code to end of
function with a label. Replace duplicate clean up code within function
with a jump to label. Invert conditional, jump to label if new
conditional evaluates to true, reduce indentation in subsequent code.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks7010_sdio.c