]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ALSA: hda: Allow setting preallocation again for x86
authorTakashi Iwai <tiwai@suse.de>
Mon, 13 Apr 2020 20:19:19 +0000 (22:19 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 13 Apr 2020 20:22:28 +0000 (22:22 +0200)
commitf8e4ae10de43fbb7ce85f79e04eca2988b6b2c40
treee6d4cb698e6fbcf511225de1425a2a01b03feab0
parent3ba21113bd33d49f3c300a23fc08cf114c434995
ALSA: hda: Allow setting preallocation again for x86

The commit c31427d0d21e ("ALSA: hda: No preallocation on x86
platforms") changed CONFIG_SND_HDA_PREALLOC_SIZE setup and its default
to zero for x86, as the preallocation should work almost all cases.
However, this expectation was too naive; some applications try to
allocate as the max buffer size as possible, and it leads to the
memory exhaustion.  More badly, the commit changed the kconfig no
longer adjustable for x86, so you can't fix it statically (although it
can be still adjusted via procfs).

So, practically seen, it's more recommended to set a reasonable limit
for x86, too.  This patch follows to that experience, and changes the
default to 2048 and allow the kconfig adjustable again.

Fixes: c31427d0d21e ("ALSA: hda: No preallocation on x86 platforms")
Cc: <stable@vger.kernel.org>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207223
Link: https://lore.kernel.org/r/20200413201919.24241-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/Kconfig