]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
KVM: arm64: Fix GICv4 init when called from vgic_its_create
authorChristoffer Dall <christoffer.dall@linaro.org>
Fri, 12 Jan 2018 10:40:21 +0000 (11:40 +0100)
committerChristoffer Dall <christoffer.dall@linaro.org>
Fri, 12 Jan 2018 10:40:21 +0000 (11:40 +0100)
commitf8f85dc00b7427de6222ea3955c52512315d13cd
tree56be5a7ae60ad2c3b59074e8add00fa73992ef0d
parentc507babf10ead4d5c8cca704539b170752a8ac84
KVM: arm64: Fix GICv4 init when called from vgic_its_create

Commit 3d1ad640f8c94 ("KVM: arm/arm64: Fix GICv4 ITS initialization
issues") moved the vgic_supports_direct_msis() check in vgic_v4_init().
However when vgic_v4_init is called from vgic_its_create(), the has_its
field is not yet set. Hence vgic_supports_direct_msis returns false and
vgic_v4_init does nothing.

The gic/its init sequence is a bit messy, so let's be specific about the
prerequisite checks in the various call paths instead of relying on a
common wrapper.

Fixes: 3d1ad640f8c94 ("KVM: arm/arm64: Fix GICv4 ITS initialization issues")
Reported-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
virt/kvm/arm/vgic/vgic-init.c
virt/kvm/arm/vgic/vgic-v4.c