]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
arm64: module: avoid undefined shift behavior in reloc_data()
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Tue, 5 Jan 2016 09:18:52 +0000 (10:18 +0100)
committerWill Deacon <will.deacon@arm.com>
Tue, 5 Jan 2016 11:27:20 +0000 (11:27 +0000)
commitf930896967fa3f9ab16a6f87267b92798308d48f
tree053df1f97b3a6f2195716ab30e5ffc747a80d234
parentb24a557527f97ad88619d5bd4c8017c635056d69
arm64: module: avoid undefined shift behavior in reloc_data()

Compilers may engage the improbability drive when encountering shifts
by a distance that is a multiple of the size of the operand type. Since
the required bounds check is very simple here, we can get rid of all the
fuzzy masking, shifting and comparing, and use the documented bounds
directly.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/module.c