]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
pinctrl: samsung: use 'int' for register masks in Exynos
authorKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thu, 8 Apr 2021 19:50:29 +0000 (21:50 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 10 Apr 2021 00:06:36 +0000 (02:06 +0200)
commitfa0c10a5f3a49130dd11281aa27e7e1c8654abc7
tree89760fcb090ef7f506274553a13b28c52dcc63ca
parentea119e5a482aaf08dd22cf53400c29cb16af8416
pinctrl: samsung: use 'int' for register masks in Exynos

The Special Function Registers on all Exynos SoC, including ARM64, are
32-bit wide, so entire driver uses matching functions like readl() or
writel().  On 64-bit ARM using unsigned long for register masks:
1. makes little sense as immediately after bitwise operation it will be
   cast to 32-bit value when calling writel(),
2. is actually error-prone because it might promote other operands to
   64-bit.

Addresses-Coverity: Unintentional integer overflow
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Link: https://lore.kernel.org/r/20210408195029.69974-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/samsung/pinctrl-exynos.c