]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
iwlegacy: avoid -Wempty-body warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 22 Mar 2021 10:43:33 +0000 (11:43 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Sun, 11 Apr 2021 09:31:01 +0000 (12:31 +0300)
commitfa9f5d0e0b45a06802f7cb3afed237be6066821e
treefe21b60e32896959fa7db6396c18f5700e708f5f
parent670d9e53886c942b7f29c475b2b494278e586921
iwlegacy: avoid -Wempty-body warning

There are a couple of warnings in this driver when building with W=1:

drivers/net/wireless/intel/iwlegacy/common.c: In function 'il_power_set_mode':
drivers/net/wireless/intel/iwlegacy/common.c:1195:60: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
 1195 |                                 il->chain_noise_data.state);
      |                                                            ^
drivers/net/wireless/intel/iwlegacy/common.c: In function 'il_do_scan_abort':
drivers/net/wireless/intel/iwlegacy/common.c:1343:57: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]

Change the empty debug macros to no_printk(), which avoids the
warnings and adds useful format string checks.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210322104343.948660-3-arnd@kernel.org
drivers/net/wireless/intel/iwlegacy/3945-mac.c
drivers/net/wireless/intel/iwlegacy/common.c
drivers/net/wireless/intel/iwlegacy/common.h