]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
PCI: Remove spurious error for sriov_numvfs store and simplify flow
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 26 Dec 2012 17:39:22 +0000 (10:39 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 26 Dec 2012 17:39:22 +0000 (10:39 -0700)
commitfaa48a507fd328013886426f9437fd7e2e7b820b
tree61c299361e749c7886d79ec6f0daad40ef947e66
parenta49f0d1ea3ec94fc7cf33a7c36a16343b74bd565
PCI: Remove spurious error for sriov_numvfs store and simplify flow

If we request "num_vfs" and the driver's sriov_configure() method enables
exactly that number ("num_vfs_enabled"), we complain "Invalid value for
number of VFs to enable" and return an error.  We should silently return
success instead.

Also, use kstrtou16() since numVFs is defined to be a 16-bit field and
rework to simplify control flow.

Reported-by: Greg Rose <gregory.v.rose@intel.com>
Reference: http://lkml.kernel.org/r/20121214101911.00002f59@unknown
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Donald Dutile <ddutile@redhat.com>
drivers/pci/pci-sysfs.c