]> git.proxmox.com Git - mirror_qemu.git/commit
hw/xen: do not set is_external=true on evtchn fds
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 16 May 2023 19:02:30 +0000 (15:02 -0400)
committerKevin Wolf <kwolf@redhat.com>
Tue, 30 May 2023 15:32:02 +0000 (17:32 +0200)
commitfb5cba2c7ee34d3c44e87374f307ebec5673cfe0
tree35cd40bbae930e95fe626365ec01735d480718bb
parentf6eac904f6825d47adc6102c8d7b59b8ba5b778e
hw/xen: do not set is_external=true on evtchn fds

is_external=true suspends fd handlers between aio_disable_external() and
aio_enable_external(). The block layer's drain operation uses this
mechanism to prevent new I/O from sneaking in between
bdrv_drained_begin() and bdrv_drained_end().

The previous commit converted the xen-block device to use BlockDevOps
.drained_begin/end() callbacks. It no longer relies on is_external=true
so it is safe to pass is_external=false.

This is part of ongoing work to remove the aio_disable_external() API.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230516190238.8401-13-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/xen/xen-bus.c