]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
Input: atmel_mxt_ts - improve T19 GPIO keys handling
authorNick Dyer <nick.dyer@itdev.co.uk>
Mon, 19 May 2014 06:00:15 +0000 (23:00 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 19 May 2014 06:27:22 +0000 (23:27 -0700)
commitfb5e4c3ee140b29e1935b4bbb19c319177bed231
tree8b633294e2d56e39f61dd88733dbbd9bd8a5e9c4
parent2cefdb1f0a27150755ef2730bafc58bf2ed16571
Input: atmel_mxt_ts - improve T19 GPIO keys handling

 * The mapping of the GPIO numbers into the T19 status byte varies between
   different maXTouch chips. Some have up to 7 GPIOs. Allowing a keycode array
   of up to 8 items is simpler and more generic. So replace #define with
   configurable number of keys which also allows the removal of is_tp.
 * Rename platform data parameters to include "t19" to prevent confusion with
   T15 key array.
 * Probe aborts early on when pdata is NULL, so no need to check.
 * Move "int i" to beginning of function (mixed declarations and code)
 * Use API calls rather than __set_bit()
 * Remove unused dev variable.

Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Acked-by: Yufeng Shen <miletus@chromium.org>
Reviewed-by: Henrik Rydberg <rydberg@euromail.se>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/atmel_mxt_ts.c
drivers/platform/chrome/chromeos_laptop.c
include/linux/i2c/atmel_mxt_ts.h