]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf()
authorVictor Gu <xigu@marvell.com>
Fri, 6 Apr 2018 14:55:31 +0000 (16:55 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 14 Aug 2018 10:24:18 +0000 (12:24 +0200)
commitfb6b5c96e68deaae8ae63af6a3434bc5d8aef492
treeea29dc30e1285dfc6be2653d77eeab53adca0c64
parentd01de60405f812a7026efb503cb8c00cfa6776d5
PCI: aardvark: Fix logic in advk_pcie_{rd,wr}_conf()

BugLink: http://bugs.launchpad.net/bugs/1778265
commit 660661afcd40ed7f515ef3369721ed58e80c0fc5 upstream.

The PCI configuration space read/write functions were special casing
the situation where PCI_SLOT(devfn) != 0, and returned
PCIBIOS_DEVICE_NOT_FOUND in this case.

However, while this is what is intended for the root bus, it is not
intended for the child busses, as it prevents discovering devices with
PCI_SLOT(x) != 0. Therefore, we return PCIBIOS_DEVICE_NOT_FOUND only
if we're on the root bus.

Fixes: 8c39d710363c1 ("PCI: aardvark: Add Aardvark PCI host controller driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Victor Gu <xigu@marvell.com>
Reviewed-by: Wilson Ding <dingwei@marvell.com>
Reviewed-by: Nadav Haklai <nadavh@marvell.com>
[Thomas: tweak commit log.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/pci/host/pci-aardvark.c