]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ptrace: Check PTRACE_O_SUSPEND_SECCOMP permission on PTRACE_SEIZE
authorJann Horn <jannh@google.com>
Sat, 19 Mar 2022 01:08:37 +0000 (02:08 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 18 May 2022 13:52:35 +0000 (15:52 +0200)
commitfb7206fb45093a41f3c9f3c902fc2f5c9f8a796c
treeb5e7e99857de2bf1f503f586699e45d12db133b8
parent4f686cc69525dc6753eb8cd23490e8907f261796
ptrace: Check PTRACE_O_SUSPEND_SECCOMP permission on PTRACE_SEIZE

BugLink: https://bugs.launchpad.net/bugs/1972740
commit ee1fee900537b5d9560e9f937402de5ddc8412f3 upstream.

Setting PTRACE_O_SUSPEND_SECCOMP is supposed to be a highly privileged
operation because it allows the tracee to completely bypass all seccomp
filters on kernels with CONFIG_CHECKPOINT_RESTORE=y. It is only supposed to
be settable by a process with global CAP_SYS_ADMIN, and only if that
process is not subject to any seccomp filters at all.

However, while these permission checks were done on the PTRACE_SETOPTIONS
path, they were missing on the PTRACE_SEIZE path, which also sets
user-specified ptrace flags.

Move the permissions checks out into a helper function and let both
ptrace_attach() and ptrace_setoptions() call it.

Cc: stable@kernel.org
Fixes: 13c4a90119d2 ("seccomp: add ptrace options for suspend/resume")
Signed-off-by: Jann Horn <jannh@google.com>
Link: https://lkml.kernel.org/r/20220319010838.1386861-1-jannh@google.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
kernel/ptrace.c