]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
usb: gadget: pch_udc: Check if driver is present before calling ->setup()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 Mar 2021 15:36:21 +0000 (17:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Mar 2021 15:53:29 +0000 (16:53 +0100)
commitfbdbbe6d3ee502b3bdeb4f255196bb45003614be
tree7de7a85aa28fde01ffd53912183fbb761c2c0dd8
parent91356fed6afd1c83bf0d3df1fc336d54e38f0458
usb: gadget: pch_udc: Check if driver is present before calling ->setup()

Since we have a separate routine for VBUS sense, the interrupt may occur
before gadget driver is present. Hence, ->setup() call may oops the kernel:

[   55.245843] BUG: kernel NULL pointer dereference, address: 00000010
...
[   55.245843] EIP: pch_udc_isr.cold+0x162/0x33f
...
[   55.245843]  <IRQ>
[   55.245843]  ? pch_udc_svc_data_out+0x160/0x160

Check if driver is present before calling ->setup().

Fixes: f646cf94520e ("USB device driver of Topcliff PCH")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210323153626.54908-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/pch_udc.c