]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
rcu: Clean up code based on review feedback from Josh Triplett
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 23 Sep 2009 16:50:41 +0000 (09:50 -0700)
committerIngo Molnar <mingo@elte.hu>
Wed, 23 Sep 2009 17:46:29 +0000 (19:46 +0200)
commitfc2219d49ef1606e7fd2c88af2b423b01ff3d319
tree1c1cba7e4334898a98cf0e2c992e8cfef4b34979
parent0729e196147692d84d4c099fcff056eba2ed61d8
rcu: Clean up code based on review feedback from Josh Triplett

These issues identified during an old-fashioned face-to-face code
review extended over many hours.

o Bury various forms of the "rsp->completed == rsp->gpnum"
comparison into an rcu_gp_in_progress() function, which has
the beneficial side-effect of forcing consistent use of
ACCESS_ONCE().

o Replace hand-coded arithmetic with DIV_ROUND_UP().

o Bury several "!list_empty(&rnp->blocked_tasks[rnp->gpnum & 0x01])"
instances into an rcu_preempted_readers() function, as this
expression indicates that there are no readers blocked
within RCU read-side critical sections blocking the current
grace period.  (Though there might well be similar readers
blocking the next grace period.)

o Remove a dangling rcu_restart_cpu() declaration that has
been dangling for almost 20 minor releases of the kernel.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: laijs@cn.fujitsu.com
Cc: dipankar@in.ibm.com
Cc: akpm@linux-foundation.org
Cc: mathieu.desnoyers@polymtl.ca
Cc: josh@joshtriplett.org
Cc: dvhltc@us.ibm.com
Cc: niv@us.ibm.com
Cc: rostedt@goodmis.org
Cc: Valdis.Kletnieks@vt.edu
Cc: dhowells@redhat.com
LKML-Reference: <12537246442687-git-send-email->
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/rcutree.h
kernel/rcutree.c
kernel/rcutree.h
kernel/rcutree_plugin.h