]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
Input: i8042 - break load dependency between atkbd/psmouse and i8042
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 25 Jul 2016 18:36:54 +0000 (11:36 -0700)
committerKamal Mostafa <kamal@canonical.com>
Thu, 15 Sep 2016 16:34:34 +0000 (09:34 -0700)
commitfc26886e5664b3c8c0751a211ca641a18cc2753c
tree933b723577ac961011a5f2e6d0eccb98d1bb6cbc
parent1b191f417e6b76b84f1424af1e4e3f1a2c81a05e
Input: i8042 - break load dependency between atkbd/psmouse and i8042

BugLink: http://bugs.launchpad.net/bugs/1621113
commit 4097461897df91041382ff6fcd2bfa7ee6b2448c upstream.

As explained in 1407814240-4275-1-git-send-email-decui@microsoft.com we
have a hard load dependency between i8042 and atkbd which prevents
keyboard from working on Gen2 Hyper-V VMs.

> hyperv_keyboard invokes serio_interrupt(), which needs a valid serio
> driver like atkbd.c.  atkbd.c depends on libps2.c because it invokes
> ps2_command().  libps2.c depends on i8042.c because it invokes
> i8042_check_port_owner().  As a result, hyperv_keyboard actually
> depends on i8042.c.
>
> For a Generation 2 Hyper-V VM (meaning no i8042 device emulated), if a
> Linux VM (like Arch Linux) happens to configure CONFIG_SERIO_I8042=m
> rather than =y, atkbd.ko can't load because i8042.ko can't load(due to
> no i8042 device emulated) and finally hyperv_keyboard can't work and
> the user can't input: https://bugs.archlinux.org/task/39820
> (Ubuntu/RHEL/SUSE aren't affected since they use CONFIG_SERIO_I8042=y)

To break the dependency we move away from using i8042_check_port_owner()
and instead allow serio port owner specify a mutex that clients should use
to serialize PS/2 command stream.

Reported-by: Mark Laws <mdl@60hz.org>
Tested-by: Mark Laws <mdl@60hz.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
drivers/input/serio/i8042.c
drivers/input/serio/libps2.c
include/linux/i8042.h
include/linux/serio.h