]> git.proxmox.com Git - mirror_qemu.git/commit
parallels: Incorrect data end calculation in parallels_open()
authorAlexander Ivanov <alexander.ivanov@virtuozzo.com>
Tue, 18 Jul 2023 10:44:24 +0000 (12:44 +0200)
committerDenis V. Lunev <den@openvz.org>
Wed, 6 Sep 2023 15:36:49 +0000 (17:36 +0200)
commitfcadb4866204fe5788969296ffce682e22109107
treea98d05e04d53733bf7a95296b30da7af15c923fd
parenta338dcbbabb04c5dc0fd36d29f14deb8669a8db6
parallels: Incorrect data end calculation in parallels_open()

The BDRVParallelsState structure contains data_end field that is measured
in sectors. In parallels_open() initially this field is set by data_off
field from parallels image header.

According to the parallels format documentation, data_off field contains
an offset, in sectors, from the start of the file to the start of the
data area. For "WithoutFreeSpace" images: if data_off is zero, the offset
is calculated as the end of the BAT table plus some padding to ensure
sector size alignment.

The parallels_open() function has code for handling zero value in
data_off, but in the result data_end contains the offset in bytes.

Replace the alignment to sector size by division by sector size and fix
the comparision with s->header_size.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
block/parallels.c