]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
b43: fix a lower bounds test
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Oct 2021 07:36:22 +0000 (10:36 +0300)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 7 Dec 2021 06:32:59 +0000 (07:32 +0100)
commitfd093f72f5ad315d0e5ab856464dd5fa1a539a91
treef98c15a004f17939c0e053f1d733385c784da884
parent08a83b945d6c92f884cf57e6ce1bf031779c8a13
b43: fix a lower bounds test

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit 9b793db5fca44d01f72d3564a168171acf7c4076 ]

The problem is that "channel" is an unsigned int, when it's less 5 the
value of "channel - 5" is not a negative number as one would expect but
is very high positive value instead.

This means that "start" becomes a very high positive value.  The result
of that is that we never enter the "for (i = start; i <= end; i++) {"
loop.  Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.

Fixes: ef1a628d83fc ("b43: Implement dynamic PHY API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211006073621.GE8404@kili
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/wireless/broadcom/b43/phy_g.c