]> git.proxmox.com Git - qemu.git/commit
projects / qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c75fead) | patch
usb-ohci: td.cbp incorrectly updated near page end
authorAndriy Gapon <avg@FreeBSD.org>
Thu, 22 Dec 2011 09:34:30 +0000 (11:34 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 6 Jan 2012 11:36:14 +0000 (12:36 +0100)
commitfd891c9318b112462e54ee1b3b16b074b8bec5b1
treea2c97b4385d2b67d012c2cad9e023f79352fefcdtree
parentc75fead66e25b35b867b661ee92087dc245a48c9commit | diff
usb-ohci: td.cbp incorrectly updated near page end

The current code that updates the cbp value after a transfer looks like this:
td.cbp += ret;
if ((td.cbp & 0xfff) + ret > 0xfff) {
<handle page overflow>
because the 'ret' value is effectively added twice the check may fire too early
when the overflow hasn't happened yet.

Below is one of the possible changes that correct the behavior:

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/usb-ohci.c diff | blob | blame | history
Qemu copy for testing