]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: ethernet: ti: am65-cpsw: fix error handling in am65_cpsw_nuss_probe()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Thu, 24 Nov 2022 03:03:08 +0000 (11:03 +0800)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 13:02:49 +0000 (14:02 +0100)
commitfdbb36f61a6b7dcb417a5db55999a818ccd9aca6
tree0ee9e235ed735fb4c44cf594681ed9f2e42e1d76
parentbe4c2779d27a552ddfe6ea0d470a921692bb2662
net: ethernet: ti: am65-cpsw: fix error handling in am65_cpsw_nuss_probe()

[ Upstream commit 46fb6512538d201d9a5b2bd7138b6751c37fdf0b ]

The am65_cpsw_nuss_cleanup_ndev() function calls unregister_netdev()
even if register_netdev() fails, which triggers WARN_ON(1) in
unregister_netdevice_many(). To fix it, make sure that
unregister_netdev() is called only on registered netdev.

Compile tested only.

Fixes: 84b4aa493249 ("net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 3bc893ef36f9ea8aa6bcc0e4333a829797ccdae4)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
drivers/net/ethernet/ti/am65-cpsw-nuss.c