]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915/bdb: Fix version check
authorLukasz Majczak <lma@semihalf.com>
Thu, 30 Sep 2021 13:46:06 +0000 (15:46 +0200)
committerJani Nikula <jani.nikula@intel.com>
Tue, 5 Oct 2021 08:52:48 +0000 (11:52 +0300)
commitfdddf8c3a477f77b3a623f220e78d45e89fc50d5
tree8705aaa68316629ea9eddaebbfcba99dba1215ec
parenta532cde31de3cae6ed60e60d6f9379771f652809
drm/i915/bdb: Fix version check

With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+"
the size of bdb_lfp_backlight_data structure has been increased,
causing if-statement in the parse_lfp_backlight function
that comapres this structure size to the one retrieved from BDB,
always to fail for older revisions.
This patch calculates expected size of the structure for a given
BDB version and compares it with the value gathered from BDB.
Tested on Chromebook Pixelbook (Nocturne) (reports bdb->version = 221)

Fixes: d381baad29b4 ("drm/i915/vbt: Fix backlight parsing for VBT 234+")
Tested-by: Lukasz Majczak <lma@semihalf.com>
Signed-off-by: Lukasz Majczak <lma@semihalf.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210930134606.227234-1-lma@semihalf.com
(cherry picked from commit 4378daf5d04eed59724e6d0e74755e17dce2e105)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_bios.c
drivers/gpu/drm/i915/display/intel_vbt_defs.h