]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
Btrfs: add another missing end_page_writeback on submit_extent_page failure
authorTakafumi Kubota <takafumi.kubota1012@sslab.ics.keio.ac.jp>
Thu, 9 Feb 2017 08:24:33 +0000 (17:24 +0900)
committerDavid Sterba <dsterba@suse.com>
Fri, 17 Feb 2017 11:03:47 +0000 (12:03 +0100)
commitfe01aa65385c226d822013b90608b67c485f8dc6
tree2bcc1b1153f87035b1cac8380007010e1564076b
parent66bbc1c0c0b283600abd187bf8c8c25ab7549307
Btrfs: add another missing end_page_writeback on submit_extent_page failure

If btrfs_bio_alloc fails in submit_extent_page, submit_extent_page returns
without clearing the writeback bit of the failed page.

__extent_writepage_io, that is a caller of submit_extent_page,
does not clear the remaining writeback bit anywhere.
As a result, this will cause the hang at filemap_fdatawait_range,
because it waits the writeback bit to be cleared from the failed page.
So, we have to call end_page_writeback to clear the writeback bit.

For reproducing the hang, we inject a fault like

   if (should_failtest()) { // I define should_failtest()
        bio = NULL;
   }
   else {
        bio = btrfs_bio_alloc(...);
   }

in submit_extent_page.

We should also check whether page has the bit before end_page_writeback,
to avoid the conflict against the other end_page_writeback in bio_endio.
Thus, we add PageWriteback checks not only in __extent_writepage_io,
but also in write_one_eb too, because it misses the check.

Signed-off-by: Takafumi Kubota <takafumi.kubota1012@sslab.ics.keio.ac.jp>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Cc: David Sterba <dsterba@suse.cz>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/extent_io.c