]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
netfilter: nf_tables: check the result of dereferencing base_chain->stats
authorLi RongQing <lirongqing@baidu.com>
Tue, 26 Feb 2019 09:13:56 +0000 (17:13 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commitfe1b4f2fe8a24d0905fd976afbebae6ca1265ce9
treef86fdf49e1eb170319e7ea6b07fbf5b67d2ba589
parent98d496d0eaa8d3f7b578a5193213c285a162b002
netfilter: nf_tables: check the result of dereferencing base_chain->stats

BugLink: https://bugs.launchpad.net/bugs/1838116
[ Upstream commit a9f5e78c403d2d62ade4f4c85040efc85f4049b8 ]

Check the result of dereferencing base_chain->stats, instead of result
of this_cpu_ptr with NULL.

base_chain->stats maybe be changed to NULL when a chain is updated and a
new NULL counter can be attached.

And we do not need to check returning of this_cpu_ptr since
base_chain->stats is from percpu allocator if it is non-NULL,
this_cpu_ptr returns a valid value.

And fix two sparse error by replacing rcu_access_pointer and
rcu_dereference with READ_ONCE under rcu_read_lock.

Thanks for Eric's help to finish this patch.

Fixes: 009240940e84c1 ("netfilter: nf_tables: don't assume chain stats are set when jumplabel is set")
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Zhang Yu <zhangyu31@baidu.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/netfilter/nf_tables_core.c