]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable
authorLyude Paul <lyude@redhat.com>
Thu, 21 Jan 2021 18:36:43 +0000 (13:36 -0500)
committerLyude Paul <lyude@redhat.com>
Fri, 22 Jan 2021 00:24:43 +0000 (19:24 -0500)
commitfe7d52bccab674a22776a2f31236bf4232e85410
treee28b90e9b1c68744b9c430f70abab9e31b81f10e
parent85da029264e83dbf1ce2f603525b0a281942c3fc
drm/i915/dp: Don't use DPCD backlights that need PWM enable/disable

We haven't yet implemented support for backlights that need to be
enabled/disabled via PWM instead of AUX, which means we'll break things if
we enable DPCD backlight control on these machines. Luckily though since
most of these machines work fine just using the plain PWM backlight
controls anyway, there shouldn't be any issue with just leaving DPCD
backlight controls disabled in such situations.

This should fix the issues with PWM being left on that were being observed
on fi-bdw-samus.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Fixes: 4a8d79901d5b ("drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)")
Testcase: igt/gem_exec_suspend/basic-s0 # fi-bdw-samus
Cc: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210121183644.2627282-1-lyude@redhat.com
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c